ci(.github): add helm-chart-node-scaling-test.yml #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
force-pushed
the
ci/add-node-scaling-test
branch
from
eb6aa93 to
b367625
Compare
voigt
approved these changes
Apr 17, 2025
Signed-off-by: Vaughn Dice <[email protected]>
vdice
force-pushed
the
ci/add-node-scaling-test
branch
from
b367625 to
80cee14
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds test automation to verify rcm's functionality in the context of node scaling.
Hoping this automation (or some variant thereof, per feedback) in combination with manual testing (say on AKS or other cloud vendors) is sufficient to close #222 cc @Mossaka
Further, I'm proposing we'll be able to remove the commented-out node_controller.go file completely -- at least until we either have a need for functionality beyond what the shim_controller does today, or we'd like to invest in a refactor to better isolate concerns.
Issue ticket number and link
Checklist before requesting a review